Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmc/2148-config_common #27

Closed
wants to merge 22 commits into from
Closed

nmc/2148-config_common #27

wants to merge 22 commits into from

Conversation

AnkurBavisa
Copy link

  1. Added "Transfer usage data" Function
  2. Added links for 'Impressum' / 'Imprint', 'Datenschutz Bestimmungen' / 'Privacy policy' and 'Verwendete Open Source Software' / 'Used open source software', Further Information

@AnkurBavisa AnkurBavisa added the custom MagentaCLOUD customisation label May 29, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

};

QTEST_MAIN(TestConfigFile)
#include "testconfigfile.moc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
testconfigfile.moc file not found

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Merging #27 (e49b12b) into master (bf0a39c) will decrease coverage by 0.07%.
The diff coverage is 5.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   60.08%   60.01%   -0.07%     
==========================================
  Files         145      145              
  Lines       18715    18733      +18     
==========================================
- Hits        11244    11243       -1     
- Misses       7471     7490      +19     
Impacted Files Coverage Δ
src/libsync/configfile.cpp 25.58% <5.00%> (-0.74%) ⬇️

... and 1 file with indirect coverage changes

@AnkurBavisa AnkurBavisa removed the custom MagentaCLOUD customisation label Jun 16, 2023
@TSI-pranalideshpande TSI-pranalideshpande added custom MagentaCLOUD customisation approved and removed approved labels Jun 22, 2023
@AnkurBavisa AnkurBavisa force-pushed the nmc/2148-config_common branch 3 times, most recently from f93847f to 1aa685d Compare June 26, 2023 09:53
@github-actions github-actions bot dismissed their stale review July 5, 2023 09:21

No clang-tidy warnings found so I assume my comments were addressed

@AnkurBavisa AnkurBavisa force-pushed the nmc/2148-config_common branch 2 times, most recently from 16ae209 to e6e910a Compare July 10, 2023 08:22
nextcloud-bot and others added 8 commits July 11, 2023 15:26
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: alex-z <blackslayer4@gmail.com>
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
@tsdicloud tsdicloud added ziteration25 This doesn't seem right and removed custom MagentaCLOUD customisation labels Aug 15, 2023
@memurats memurats closed this Sep 30, 2024
@memurats memurats deleted the nmc/2148-config_common branch September 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ziteration25 This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants