Nmc/generalsettings manage component visibility local #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -60,6 +60,7 @@ class OWNCLOUDSYNC_EXPORT ConfigFile | |||
| [[nodiscard]] bool showConfigBackupWarning() const; | |||
|
|
|||
| bool exists(); | |||
| bool isWidgetVisible() const; | |||
There was a problem hiding this comment.
function isWidgetVisible should be marked [[nodiscard]]
Suggested change
| bool isWidgetVisible() const; | |
| [[nodiscard]] bool isWidgetVisible() const; |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 60.36% 60.07% -0.30%
==========================================
Files 143 146 +3
Lines 18518 18719 +201
==========================================
+ Hits 11179 11246 +67
- Misses 7339 7473 +134
|
AnkurBavisa
force-pushed
the
nmc/generalsettings_manage_component_visibility_local
branch
from
9cf3d91
to
fdd508f
Compare
Signed-off-by: Ankur Bavisa <Ankur.Bavisa@t-systems.com>
AnkurBavisa
force-pushed
the
nmc/generalsettings_manage_component_visibility_local
branch
from
fdd508f
to
0bde8d7
Compare
tsdicloud
added
ziteration25
memurats
deleted the
nmc/generalsettings_manage_component_visibility_local
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary create PR of upstream PR