Skip to content

[V33] Redirect after access denied error #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
memurats wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[V33] Redirect after access denied error #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae69f4
added check and redirect
memurats Oct 29, 2025
8c19fdc
fixed merge error
memurats Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lib/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,11 @@ public function code(string $state = '', string $code = '', string $scope = '',
$this->logger->debug('Code login with core: ' . $code . ' and state: ' . $state);

if ($error !== '') {
if (!$this->isMobileDevice()) {
$cancelRedirectUrl = $this->config->getSystemValue('user_oidc.cancel_redirect_url', 'https://cloud.telekom-dienste.de/');
return new RedirectResponse($cancelRedirectUrl);
}

$this->logger->warning('Code login error', ['error' => $error, 'error_description' => $error_description]);
if ($this->isDebugModeEnabled()) {
return new JSONResponse([
Expand Down Expand Up @@ -910,4 +915,20 @@ private function toCodeChallenge(string $data): string {
$s = str_replace('/', '_', $s); // 63rd char of encoding
return $s;
}

private function isMobileDevice(): bool {
$mobileKeywords = $this->config->getSystemValue('user_oidc.mobile_keywords', ['Android', 'iPhone', 'iPad', 'iPod', 'Windows Phone', 'Mobile', 'webOS', 'BlackBerry', 'Opera Mini', 'IEMobile']);

if (!isset($_SERVER['HTTP_USER_AGENT'])) {
return false; // if no user-agent is set, assume desktop
}

foreach ($mobileKeywords as $keyword) {
if (stripos($_SERVER['HTTP_USER_AGENT'], $keyword) !== false) {
return true; // device is mobile
}
}

return false; // device is desktop
}
}
Loading