Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change naming scheme #33

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Change naming scheme #33

merged 3 commits into from
Aug 21, 2024

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Aug 21, 2024 •
edited
Loading

Linked PR: nextsimhub/nextsimdg#652.

At meeting in Bergen, it was decided that we should rename some of the variables printed in the NetCDF metadata as follows:

globalX -> NX
globalY -> NY
global_x ->  domain_x
global_y ->  domain_y
local_extent_x -> domain_extent_x
local_extent_y -> domain_extent_y

@jwallwork23 jwallwork23 added the enhancement New feature or request label Aug 21, 2024
@jwallwork23 jwallwork23 self-assigned this Aug 21, 2024
This was referenced Aug 21, 2024
Merged
Open
@jwallwork23 jwallwork23 changed the base branch from main to melt-update-readme August 21, 2024 12:48
@jwallwork23 jwallwork23 marked this pull request as ready for review August 21, 2024 12:51
@jwallwork23 jwallwork23 mentioned this pull request Aug 21, 2024
Open
27 tasks
jwallwork23 added a commit to nextsimhub/nextsimdg that referenced this pull request Aug 21, 2024
@jwallwork23
Use updated domain_decomp naming scheme (#652)
fcd23f8 
# Use updated `domain_decomp` naming scheme

Linked PR: nextsimhub/domain_decomp#33.
@jwallwork23
Copy link
Contributor Author

We decided to just merge this in.

@jwallwork23 jwallwork23 merged commit a624709 into melt-update-readme Aug 21, 2024
2 checks passed
@jwallwork23 jwallwork23 deleted the issue32_relabelling branch August 21, 2024 13:29
@jwallwork23 jwallwork23 mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMelt TomMelt Awaiting requested review from TomMelt

@einola einola Awaiting requested review from einola

@timspainNERSC timspainNERSC Awaiting requested review from timspainNERSC

Assignees

@jwallwork23 jwallwork23

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwallwork23