Partitioner refactor 1 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMelt
approved these changes
Sep 17, 2024
|
|
||
| // Create 2 dimensions | ||
| // The values to be written are associated with the netCDF variable by | ||
| // assuming that the last dimension of the netCDF variable varies fastest in | ||
| // the C interface | ||
| const int NDIMS = 2; | ||
| const int NDIMS = 2; // TODO: Why redeclared? |
There was a problem hiding this comment.
Agreed. It is also defined in Grid.cpp. I think we will only ever work with a 2D landmask. So I don't know why it's defined so many times.
I am not suggesting to change as part of this PR but perhaps we can factor this out in the second round
| } | ||
|
|
||
| // There are two neighbours for each dimension | ||
| const int NNBRS = NDIMS * 2; // TODO: Why redeclared? |
There was a problem hiding this comment.
I guess when we figure out the other one we can remove this too?
|
Thanks @TomMelt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first refactoring of the
Partitionerclass.Main changes
get_top_neighbours,get_bottom_neighbours, etc. into a single method._0or_1into vectors.These changes cut down duplication and will make it easier to switch direction orderings.
Future work
Some of this gets propagated through to the
ZoltanPartitionerclass but it will need further refactoring. There is also further refactoring to be done handling the bounding boxes.