Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize existing pathogen build workflows #46

Closed
5 of 6 tasks
joverlee521 opened this issue Jul 27, 2023 · 4 comments
Closed
5 of 6 tasks

Centralize existing pathogen build workflows #46

joverlee521 opened this issue Jul 27, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Jul 27, 2023

Context

We now have a centralized reusable GitHub Action workflow for running pathogen builds.

We should update existing pathogen build workflows to use the centralized workflow to make future maintenance easier for ourselves and to discover any pitfalls in reusable workflow that may have been overlooked during development.

Hopefully there shouldn't be any huge changes that need to happen to the reusable workflow, but better to discover them now than later when it's widely used.

Description

Here's a list of repos that should be updated to use the new workflow:

Examples

See example use of the reusable workflow in seasonal-flu

@joverlee521 joverlee521 added the enhancement New feature or request label Jul 27, 2023
@joverlee521 joverlee521 self-assigned this Feb 15, 2024
@genehack
Copy link
Contributor

@joverlee521 looks like the only unticked box in the original TODO list is for ncov, and I see a merged PR against ncov ...is this issue maybe done?

@joverlee521
Copy link
Contributor Author

@genehack The merged PR is for ncov-ingest which is a separate repo than ncov. The ncov GH Action workflows still need to be migrated.

@genehack
Copy link
Contributor

The need to update the CI workflow in ncov has been moved to a new issue in the ncov repo.

Closing this issue out.

@joverlee521
Copy link
Contributor Author

@genehack, I completely misread your previous issue! This is actually regarding the use of the pathogen-repo-build workflow. I've made a new issue to track the separate task: nextstrain/ncov#1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants