Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Suffolk" in lat_longs.tsv points to somewhere unexpected #155

Open
fanninpm opened this issue Feb 27, 2024 · 1 comment · May be fixed by #156
Open

"Suffolk" in lat_longs.tsv points to somewhere unexpected #155

fanninpm opened this issue Feb 27, 2024 · 1 comment · May be fixed by #156
Labels
bug Something isn't working

Comments

@fanninpm
Copy link

Current Behavior

In the lat_longs.tsv file, Suffolk points to somewhere in Boston Harbor.

Expected behavior

"Suffolk" should point to somewhere in the East of England/East Anglia, not too far from "Norfolk", "Essex", and "Cambridgeshire".

How to reproduce

Steps to reproduce the current behavior:

  1. Visit https://www.gps-coordinates.net/
  2. Copy/paste the coordinates associated with "Suffolk" (which are currently 42.3544455 degrees in latitude and -70.9788771 in longitude)
  3. Observe the location on the map

Possible solution

I don't know enough about how Nextstrain divides the UK in its lat_longs.tsv file to give directions for a possible solution. However, I think this may indicate a broader issue as for the structure of the lat_longs.tsv file itself. Perhaps there should be more hierarchy in that file, which would answer additional questions such as "Should Hawaii's region value be 'Oceania' (because it's out in the middle of the Pacific) or 'North America' (because it's part of the USA)?".

Additional context

For my purposes, I will use "Suffolk ENG" as my location value in my metadata.
@fanninpm fanninpm added the bug Something isn't working label Feb 27, 2024
@joverlee521
Copy link
Contributor

Thank you for reporting this issue @fanninpm!

Looks like the current Suffolk lat/long points to the same coordinates as the Suffolk County MA lat/long.

Looking at the commit history (90cbd77), the seasonal-flu lat_long.tsv was copied over from the ncov/defaults/lat_longs.tsv so we'll need to fix both entries.

joverlee521 added a commit that referenced this issue Feb 27, 2024
@joverlee521
Update Suffolk lat/longs
69152d1 
Fixes #155

Interestingly, we don't have any entries for "Suffolk" in the
fauna/source-data/geo_synonyms.tsv¹ and I couldn't find any metadata
in our private S3 bucket that includes "Suffolk" as a location.

¹ https://github.com/nextstrain/fauna/blob/75e309e9afe2cc97fb56d7a24e22a07b698805bf/source-data/geo_synonyms.tsv
@joverlee521 joverlee521 linked a pull request Feb 27, 2024 that will close this issue
Open
1 task
joverlee521 added a commit to nextstrain/ncov that referenced this issue Feb 27, 2024
@joverlee521
Update Suffolk lat/long
27d929e 
Prompted by nextstrain/seasonal-flu#155.

The "Suffolk" location should be the location in UK based on
ncov-ingest/source-data/gisaid_geoLocationRules.tsv¹ since all other
"Suffolk" entries are corrected to "Suffolk County".

¹ https://github.com/nextstrain/ncov-ingest/blob/d3fa3b990ea417e3188537e1125f032169e55b69/source-data/gisaid_geoLocationRules.tsv
@joverlee521 joverlee521 mentioned this issue Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Suffolk lat/longs nextstrain/seasonal-flu
2 participants
@fanninpm @joverlee521