Merged
Conversation
cretz
approved these changes
May 2, 2024
bergundy
added a commit
to nexus-rpc/sdk-go
that referenced
this pull request
May 2, 2024
Make adjustments based on the spec changes mentioned here: nexus-rpc/api#5
bergundy
added a commit
to temporalio/temporal
that referenced
this pull request
May 9, 2024
## What changed? - Refactored Nexus Registry code to merge incoming and outgoing into one registry - Added separate concept of "endpoints" - which is roughly analogous to what was previously called "services" - Upgraded the Nexus Go SDK and API dependencies accordingly - Command handler interface was modified to accept a context given new requirements - Note that invoking a worker endpoint is not yet supported, there will be some minor restructuring required to enable that - Requires this unmerged API PR temporalio/api#403. The two PRs should be merged together. ## Why? Part of late redesign. See also nexus-rpc/api#5 ## How did you test it? Modified existing and added new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After internal discussions and review for adding Nexus APIs into the Temporal Go SDK it was decided that "Service" should be a well-defined Nexus concept.
The original design was more free-form and left this concept out.
Services are an important concept in Nexus, modeled after gRPC services.
Service consumers will want to browse for services by functionality and decoupling the service from the endpoint in which it is served on, allows for better discoverability.