fix: fix redundant path in error message #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing per policy to not accept minor cosmetic fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this resolving a feature or a bug?
This is neither a feature nor a bug fix, but a small improvement to the clarity and simplicity of an error message.
Are there existing issue(s) that this PR would close?
No, this is not tied to any existing issues.
If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.
This PR is minimal and focuses solely on improving the error message.
Describe your changes.
In the error message for file path not found, the path
"target/riscv32i-unknown-none-elf/release/"was being duplicated unnecessarily since it’s already included inTARGET_PATH. I updated thepanic!statement to usepath.display(), which directly provides the full path in the error message, making it more concise and informative. This eliminates redundancy and improves readability.