Skip to content

Remove BOLD-based databases for plant taxonomic classification with DADA2 #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 6, 2025

Conversation

Sofokli5
Copy link
Contributor

@Sofokli5 Sofokli5 commented Jun 6, 2025

BOLD databases ('plantae-bold-its1' & 'plantae-bold-trnL') added with PR #883 included low quality sequences.
Removing these databases, after discussions within the METAPLANTCODE project.
Extra curation is necessary.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Sofokli5 added 5 commits June 6, 2025 10:42
Remove databases info
Remove databases options
Remove databases parameters
Removing databases log
@Sofokli5 Sofokli5 requested a review from d4straub June 6, 2025 08:05
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thats a pity. Will you do the curation and add it later again?
PR looks good to me.

@Sofokli5
Copy link
Contributor Author

Sofokli5 commented Jun 6, 2025

Oh thats a pity. Will you do the curation and add it later again? PR looks good to me.

Most definitely!!

@Sofokli5 Sofokli5 merged commit a9f5d31 into nf-core:dev Jun 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants