Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template version 2.14.1 #393

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Merge template version 2.14.1 #393

merged 9 commits into from
Jul 2, 2024

Conversation

JoseEspinosa
Copy link
Member

Merge template version 2.14.1

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit db32e8b

+| ✅ 227 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-02 09:02:08

maxulysse
maxulysse reviewed Jul 2, 2024
View reviewed changes
modules.json Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say you have some delete subworkflows in the modules.json, but apart from that, looks ok to me

@JoseEspinosa
Copy link
Member Author

JoseEspinosa commented Jul 2, 2024 •
edited
Loading

I'd say you have some delete subworkflows in the modules.json, but apart from that, looks ok to me

Thanks @maxulysse! I think it is fixed now would be great if you could take a look.

@JoseEspinosa JoseEspinosa merged commit 1b94331 into nf-core:dev Jul 2, 2024
9 checks passed
@JoseEspinosa JoseEspinosa deleted the merge_template_v2.14.1 branch July 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @maxulysse @nf-core-bot