Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing defaults to documentation #90

Merged
merged 2 commits into from
Jan 26, 2024
Merged

add missing defaults to documentation #90

merged 2 commits into from
Jan 26, 2024

Conversation

MariekeVromman
Copy link
Contributor

@MariekeVromman MariekeVromman commented Jan 24, 2024 •
edited
Loading

PR checklist

Updates of the documentation

  • added the default values for a couple of parameters in the help function
  • updated some of the markdown code to display the 'note', 'tip' and 'warning' fields (not sure if this worked)

@MariekeVromman MariekeVromman added the documentation Improvements or additions to documentation label Jan 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 87b1026

+| ✅ 162 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • system_exit - System.exit in circrna.nf: System.exit(1) [line 43]

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-25 16:06:03

@MariekeVromman MariekeVromman requested a review from nictru January 25, 2024 16:19
@nservant nservant self-assigned this Jan 26, 2024
@nservant nservant self-requested a review January 26, 2024 16:23
@nservant nservant removed their assignment Jan 26, 2024
nservant
nservant approved these changes Jan 26, 2024
View reviewed changes
Copy link

@nservant nservant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good

@MariekeVromman MariekeVromman merged commit 6268eb5 into nf-core:dev Jan 26, 2024
6 checks passed
@MariekeVromman MariekeVromman deleted the documentation branch February 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nservant nservant nservant approved these changes

@nictru nictru nictru approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariekeVromman @nservant @nictru