Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uw_hyak_pedslabs config #486

Merged
merged 17 commits into from
Jul 8, 2023
Merged

Added uw_hyak_pedslabs config #486

merged 17 commits into from
Jul 8, 2023

Conversation

CarsonJM
Copy link
Contributor

@CarsonJM CarsonJM commented Apr 7, 2023


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay! Apparently all our notifications for this repo stopped...

Overall LGTM but please check the docs.md of other configs to make sure you keep roughly to the same structure (we will likely have better (read: actual) docs rendering on the nf-core website soon, so we want to have a certain level of standardisation) [also see prettier error]

@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

@CarsonJM
Copy link
Contributor Author

CarsonJM commented Jul 5, 2023

@nf-core-bot fix linting

@maxulysse maxulysse merged commit 7f7a34b into nf-core:master Jul 8, 2023
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants