Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shinx cluster to VSC ugent + simplification in usage of config #719

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented Jul 18, 2024

A new cluster has been added to the HPC

This PR also makes the usage of the config easier while staying backwards compatible

TODOS:

  • Update and prettify documentation
  • Properly test the config

Copy link
Contributor

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works!

@jfy133 jfy133 marked this pull request as draft July 18, 2024 11:26
@nvnieuwk nvnieuwk marked this pull request as ready for review July 22, 2024 07:36
@nvnieuwk nvnieuwk merged commit 48b0fdc into nf-core:master Jul 22, 2024
128 checks passed
@nvnieuwk nvnieuwk deleted the vsc_ugent/shinx branch July 22, 2024 07:38
@nvnieuwk
Copy link
Contributor Author

I ran tests on all major tier2 clusters and they all succeeded. Merging this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants