Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logo #208

Closed
wants to merge 2 commits into from
Closed

update logo #208

wants to merge 2 commits into from

Conversation

suzannejin
Copy link
Contributor

  • move the nf-core logo a little to the right so that it can be seen better

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/deepmodeloptim branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

mashehu
mashehu reviewed Nov 6, 2024
View reviewed changes
assets/nf-core-deepmodeloptim_logo_light.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something happened with the dash here... can you try to recreate it with nf-core pipelines create-logo deepmodeloptim --format svg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is exactly what i did.. create the logo using nf-core, and then add the cat-snack logo..
what is weird with the dash?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have some space to "core" it looks like it is overlapping now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird... i tried to create-logo once again, and even the original logo has this weird dash problem...
I fixed it manually now though.. not sure if there is a better way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what vector graphics program are you using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use inkspace.. when i open the svg using inkspace it look all right after the edition, but on github everything still look over the place somehow

@mashehu mashehu mentioned this pull request Nov 6, 2024
Merged
@suzannejin suzannejin closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu left review comments

@mathysgrapotte mathysgrapotte Awaiting requested review from mathysgrapotte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suzannejin @mashehu