Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMPCOMBI/PASRSETABLE default resources very underpowered #451

Closed
jfy133 opened this issue Feb 6, 2025 · 7 comments · Fixed by #454
Closed

AMPCOMBI/PASRSETABLE default resources very underpowered #451

jfy133 opened this issue Feb 6, 2025 · 7 comments · Fixed by #454
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Feb 6, 2025

Description of the bug

Currently set to 6 CPUs, whereas recommendation from @Darcy220606 is at least 40

Command used and terminal output

Relevant files

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label Feb 6, 2025
@Darcy220606
Copy link
Contributor

Darcy220606 commented Feb 6, 2025

U still want to bump that? As I said it depends on the dataset size. 40 is too much for normal datasets also.

@jasmezz
Copy link
Collaborator

jasmezz commented Feb 6, 2025

What's a "normal" average size then and what would be the dataset size recommended for 40 CPUs (do you mean the wastewater one that James is running?)?

@jfy133
Copy link
Member Author

jfy133 commented Feb 6, 2025

Yes we should probably bump it.

6 works for our tiny fake dataset, 40 needed for a huge thing, so somewhere in the middle. Maybe 16?

@Darcy220606
Copy link
Contributor

Im testing it always with two of our samples using 12 and thats enough

@jfy133
Copy link
Member Author

jfy133 commented Feb 10, 2025

Enough in what way?

@jasmezz
Copy link
Collaborator

jasmezz commented Feb 13, 2025

Let's agree on this before 2.1 release? I don't have much experience with this module's requirements. I would rather choose a slightly higher value in favor of module not crashing. Let's go for 16?

@jasmezz jasmezz linked a pull request Feb 13, 2025 that will close this issue
11 tasks
@jasmezz
Copy link
Collaborator

jasmezz commented Feb 13, 2025

Solved by #454

@jasmezz jasmezz closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants