Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.1 #5

Merged
merged 9 commits into from
Jun 26, 2023
Merged

v1.0.1 #5

merged 9 commits into from
Jun 26, 2023

Conversation

matq007
Copy link
Member

@matq007 matq007 commented Jun 22, 2023 •
edited
Loading

Fixed minor mistakes and AWS testing!

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/marsseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matq007 matq007 requested a review from maxulysse June 22, 2023 18:34
@matq007 matq007 marked this pull request as ready for review June 22, 2023 18:35
@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2d3b531

+| ✅ 158 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-26 06:57:17

maxulysse
maxulysse approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

nextflow.config Outdated Show resolved Hide resolved
@matq007
Copy link
Member Author

matq007 commented Jun 22, 2023 •
edited
Loading

TODO before merge:

  • bump-version to 1.0.1
  • update CHANGELOG release date

JoseEspinosa
JoseEspinosa approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

maxulysse
maxulysse reviewed Jun 26, 2023
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matq007 matq007 merged commit 0ca38c3 into master Jun 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matq007 @maxulysse @JoseEspinosa