-
Notifications
You must be signed in to change notification settings - Fork 946
Update glimpse2 imputation subworkflow #9434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Needs #9467 to be merged. |
f738955 to
03a1f54
Compare
subworkflows/nf-core/bam_vcf_impute_glimpse2/tests/main.nf.test
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan Manning <pininforthefjords@gmail.com>
Co-authored-by: Jonathan Manning <pininforthefjords@gmail.com>
| // Error if pre-defined chunks are provided when chunking is activated | ||
| ch_chunks | ||
| .filter { _meta, regionin, regionout -> regionin.size() > 0 || regionout.size() > 0 } | ||
| .subscribe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this subscribe feels strange to me, and I don't see it used in other subworkflows. Could we use the same ifEmpty pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will do so before merging !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to
ch_chunks
.filter { _meta, regionin, regionout -> regionin.size() == 0 && regionout.size() == 0 }
.ifEmpty {
error "ERROR: Cannot provide pre-defined chunks (regionin) when chunk=true. Please either set chunk=false to use provided chunks, or remove input chunks to enable automatic chunking."
}
pinin4fjords
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock you because I feel guilty for being distracted for a couple of days! Still wondering about the subscribe, but will leave you to resolve.
No worries ! |
You have my approval :-) |
PR checklist
Add genetic map in main tuple for GLIMPSE2_splitreference for parallelization purpose
Change glimpse2 imputation subworkflow from
MULTIPLEtoBAM_VCFto follow conventionMake chunking and reference split optional.
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda