Skip to content

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Nov 20, 2025

PR checklist

Add genetic map in main tuple for GLIMPSE2_splitreference for parallelization purpose
Change glimpse2 imputation subworkflow from MULTIPLE to BAM_VCF to follow convention
Make chunking and reference split optional.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet
Copy link
Contributor Author

Needs #9467 to be merged.

// Error if pre-defined chunks are provided when chunking is activated
ch_chunks
.filter { _meta, regionin, regionout -> regionin.size() > 0 || regionout.size() > 0 }
.subscribe {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this subscribe feels strange to me, and I don't see it used in other subworkflows. Could we use the same ifEmpty pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will do so before merging !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to

ch_chunks
            .filter { _meta, regionin, regionout -> regionin.size() == 0 && regionout.size() == 0 }
            .ifEmpty {
                error "ERROR: Cannot provide pre-defined chunks (regionin) when chunk=true. Please either set chunk=false to use provided chunks, or remove input chunks to enable automatic chunking."
            }

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock you because I feel guilty for being distracted for a couple of days! Still wondering about the subscribe, but will leave you to resolve.

@LouisLeNezet
Copy link
Contributor Author

Approving to unblock you because I feel guilty for being distracted for a couple of days! Still wondering about the subscribe, but will leave you to resolve.

No worries !
Is it better with this version ?

@pinin4fjords
Copy link
Member

Approving to unblock you because I feel guilty for being distracted for a couple of days! Still wondering about the subscribe, but will leave you to resolve.

No worries ! Is it better with this version ?

You have my approval :-)

@LouisLeNezet LouisLeNezet added this pull request to the merge queue Dec 11, 2025
Merged via the queue into nf-core:master with commit 73072bd Dec 11, 2025
53 checks passed
@LouisLeNezet LouisLeNezet deleted the sbwf_glimpse2 branch December 11, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants