Skip to content

Conversation

@LouisLeNezet
Copy link
Contributor

PR checklist

Fix some of the change made in nf-core/test-datasets#1796
Imputation software will be updated in separated PR.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet marked this pull request as ready for review November 26, 2025 16:02
@LouisLeNezet
Copy link
Contributor Author

Needs #9463 to be merged

@LouisLeNezet LouisLeNezet self-assigned this Nov 26, 2025
@LouisLeNezet LouisLeNezet added this pull request to the merge queue Dec 10, 2025
Merged via the queue into nf-core:master with commit 345b60f Dec 10, 2025
160 of 164 checks passed
@LouisLeNezet LouisLeNezet deleted the upd_test_error branch December 10, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants