Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema #205

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Update schema #205

merged 5 commits into from
Oct 28, 2024

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Oct 25, 2024

Fixes #200

PR checklist

  • This comment contains a description of changes (with reason).
  • If necessary, also make a PR on the nf-core/proteinfold branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a006829

+| ✅ 205 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-28 10:11:21

@luisas luisas added the WIP Work in progress label Oct 25, 2024
@luisas
Copy link
Contributor Author

luisas commented Oct 25, 2024

this won't run until this is merged: nf-core/test-datasets#1362

@luisas luisas mentioned this pull request Oct 25, 2024
Closed
@JoseEspinosa JoseEspinosa changed the title change schema Update schema Oct 28, 2024
JoseEspinosa
JoseEspinosa requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please udpate the changelog and once tests pass we are ready to merge :rocket

JoseEspinosa
JoseEspinosa requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please udpate the changelog and once tests pass we will be ready to merge 🚀

JoseEspinosa
JoseEspinosa reviewed Oct 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
JoseEspinosa
JoseEspinosa approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@luisas luisas merged commit 43337b6 into nf-core:dev Oct 28, 2024
18 checks passed
@JoseEspinosa JoseEspinosa mentioned this pull request Oct 28, 2024
Open
11 tasks
@JoseEspinosa JoseEspinosa added enhancement Improvement for existing functionality and removed WIP Work in progress labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
enhancement Improvement for existing functionality
Projects
Hackathon October 2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisas @JoseEspinosa