Skip to content

Conversation

@suhrig
Copy link

@suhrig suhrig commented Jan 18, 2026

This PR adds another (experimental) quantification method for Ribo-seq data. Instead of counting all Ribo-seq reads which map to a transcript, this new method only counts reads which map to coding regions (CDS) and only if the P-sites computed by Plastid align with the reading frame of the coding region. This means the quantification method is fairly conservative, ignoring frame-shifted reads or reads mapping to unannotated coding regions. RNA-seq quantification is unchanged.

The user can enable this quantification method by setting --te_quantification_method to the value plastid_psite. It is off by default. The method is implemented as a local module (essentially bedtools intersect).

I meant to add a test for this new quantification method, but the inputs to the module are not deterministic to begin with which means the outputs aren't either, making a test rather pointless.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@suhrig
Copy link
Author

suhrig commented Jan 18, 2026

@nf-core-bot fix linting

@suhrig suhrig marked this pull request as draft January 18, 2026 19:58
@suhrig suhrig marked this pull request as ready for review January 19, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants