Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Added ref to downstream analyses #1060

Merged
merged 2 commits into from
Aug 16, 2023
Merged

README.md: Added ref to downstream analyses #1060

merged 2 commits into from
Aug 16, 2023

Conversation

smoe
Copy link
Contributor

@smoe smoe commented Jul 14, 2023

At a first glance, an "RNA-seq workflow" suggests an inclusion of a differential analysis of expression since it offers samples to be grouped and also runs DESeq2 on the basis of that grouping, i.e. what would also be run to determine a differential abundance. The emphasis on QA makes perfect sense but is not strongly communicated.

I suggest to add this paragraph to avoid the possibility of a disappointment for your novice users who (like us, admittedly) may not be aware of that second dedicated workflow to exist.

@smoe smoe mentioned this pull request Jul 20, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a55caf0

+| ✅ 143 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-02 21:14:09

drpatelh
drpatelh reviewed Aug 2, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
drpatelh
drpatelh approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🙏

@maxulysse maxulysse merged commit 29f8b39 into nf-core:dev Aug 16, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoe @drpatelh @maxulysse