Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid named parameter syntax #1376

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Fix invalid named parameter syntax #1376

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b6915c
Update main.nf
pditommaso Sep 6, 2024
41bbfdf
Merge branch 'dev' into pditommaso-patch-1
ewels Sep 6, 2024
5d20e28
Update CHANGELOG.md
pinin4fjords Sep 10, 2024
41b44b0
Merge branch 'dev' into pditommaso-patch-1
maxulysse Sep 20, 2024
82c833d
Apply suggestions from code review
maxulysse Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## v3.16.0dev - [date]


maxulysse marked this conversation as resolved.
Show resolved Hide resolved
### Enhancements & fixes

- [PR #1388](https://github.com/nf-core/rnaseq/pull/1351) - Adding Kraken2/Bracken on unaligned reads as an additional quality control step to detect sample contamination
- [PR #1186](https://github.com/nf-core/rnaseq/pull/1186) - Bump pipeline version to 3.16.0dev
- [PR #1376](https://github.com/nf-core/rnaseq/pull/1376) - Fix invalid named parameter syntax
- [PR #1386](https://github.com/nf-core/rnaseq/pull/1386) - Bump pipeline version to 3.16.0dev
- [PR #1388](https://github.com/nf-core/rnaseq/pull/1388) - Adding Kraken2/Bracken on unaligned reads as an additional quality control step to detect sample contamination

### Parameters

Expand Down
2 changes: 1 addition & 1 deletion workflows/rnaseq/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ workflow RNASEQ {
ch_strand_comparison = BAM_RSEQC.out.inferexperiment_txt
.map {
meta, strand_log ->
def rseqc_inferred_strand = getInferexperimentStrandedness(strand_log, stranded_threshold = params.stranded_threshold, unstranded_threshold = params.unstranded_threshold)
def rseqc_inferred_strand = getInferexperimentStrandedness(strand_log, params.stranded_threshold, params.unstranded_threshold)
rseqc_strandedness = rseqc_inferred_strand.inferred_strandedness

def status = 'fail'
Expand Down
Loading