Skip to content
This repository was archived by the owner on May 5, 2020. It is now read-only.

Updated base code to pass nf-core lint tests #30

Merged
merged 5 commits into from
Sep 25, 2018
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Sep 24, 2018

Fixes #29 and docker tag issue in #28

Linting tests now pass with warnings locally.

@ewels ewels requested a review from a team September 24, 2018 11:26
@ewels ewels changed the base branch from master to dev September 24, 2018 11:35
@ewels
Copy link
Member Author

ewels commented Sep 24, 2018

Updated PR to point to dev branch, so that tests will run.

@ewels
Copy link
Member Author

ewels commented Sep 24, 2018

Removed the pipeline tests and updated the pipeline so that lint tests now pass! 🎉 (at least when the anaconda API doesn't time out).

Ready for merge if everyone's happy.

Phil

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@apeltzer apeltzer merged commit af06171 into nf-core:dev Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants