fix: default PSA pin status filter (#1936)

packages/api/src/routes/pins-list.js

@@ -123,6 +123,10 @@ function parseSearchParams(params) {
     out.status = /** @type {ListUploadsOptions["status"]}*/ (
       statusParam.split(',').map(toDbPinStatus)
     )
+  } else {
+    // "when no filter is provided, only successful pins are returned"
+    // https://ipfs.github.io/pinning-services-api-spec/#tag/pins/paths/~1pins/get
+    out.status = ['Pinned']
   }
 
   const afterParam = params.get('after')

packages/api/test/pin-list.spec.js

@@ -1,11 +1,15 @@
 import assert from 'assert'
-import { createClientWithUser, DBTestClient } from './scripts/helpers.js'
+import {
+  createClientWithUser,
+  DBTestClient,
+  rawClient,
+} from './scripts/helpers.js'
 
 describe('Pin list ', () => {
   /** @type{DBTestClient} */
   let client
 
-  before(async () => {
+  beforeEach(async () => {
     client = await createClientWithUser()
   })
 
@@ -70,4 +74,22 @@ describe('Pin list ', () => {
       'Server response with pin requests created'
     )
   })
+
+  it('should list pinned items when querying without filters', async () => {
+    // Pin request (unavailable on IPFS)
+    const cid = 'bafkreiaoqabl7yiracpil3m7rgbgygky2wwqtvzom2lkdhy2pxchkjixae'
+    await client.addPin({ cid, name: 'test' })
+
+    // Make this CID 'Pinned' in our DB
+    await rawClient
+      .from('pin')
+      .update({ status: 'Pinned', updated_at: new Date().toISOString() })
+      .eq('content_cid', cid)
+
+    const headers = { Authorization: `Bearer ${client.token}` }
+    const res = await fetch('pins', { headers })
+    const { count, results } = await res.json()
+    assert.strictEqual(count, 1)
+    assert.strictEqual(results[0].pin.cid, cid)
+  })
 })