User microposts by nghiadk1102 · Pull Request #14 · nghiadk1102/sample_app

nghiadk1102 · 2017-07-03T01:07:47Z

No description provided.

nghiadk1102 · 2017-07-03T02:18:24Z

ready

huongnguyenmta · 2017-07-03T15:32:02Z

app/controllers/application_controller.rb

+     return if logged_in?
+     store_location
+     flash[:danger] = t ".please_login"
+     redirect_to login_url


fix all indent from line 8-11

huongnguyenmta · 2017-07-03T15:32:24Z

app/controllers/microposts_controller.rb

+  before_action :correct_user, only: :destroy
+
+  def create
+    @micropost = current_user.microposts.build micropost_params


Thêm 1 dòng trống phía dưới

huongnguyenmta · 2017-07-03T15:33:00Z

app/controllers/microposts_controller.rb

+    def correct_user
+      @micropost = current_user.microposts.find_by id: params[:id]
+      redirect_to root_url if @micropost.nil?
+    end


fix all indent from line 24-31

huongnguyenmta · 2017-07-03T15:33:49Z

app/helpers/microposts_helper.rb

@@ -0,0 +1,2 @@
+module MicropostsHelper


File này chưa dùng đến bạn xóa đi nhé

huongnguyenmta · 2017-07-03T15:34:44Z

app/models/micropost.rb

+class Micropost < ApplicationRecord
+  belongs_to :user
+
+  default_scope -> {order created_at: :desc}


Bạn viết 1 scope để dùng chứ không dùng default_scope như này nhé

huongnguyenmta · 2017-07-03T15:35:07Z

app/models/micropost.rb

+  validates :user_id, presence: true
+  validates :content, presence: true,
+    length: {maximum: Settings.model.microposts.size_post}
+  validate  :picture_size


thừa khoảng trắng: => validate :picture_size

huongnguyenmta · 2017-07-03T15:35:53Z

app/uploaders/picture_uploader.rb

+class PictureUploader < CarrierWave::Uploader::Base
+  include CarrierWave::MiniMagick
+
+  process resize_to_limit: [400, 400]


move 400 into Settings

huongnguyenmta · 2017-07-03T15:36:39Z

app/views/shared/_micropost_form.html.erb

@@ -0,0 +1,19 @@
+<%= form_for(@micropost) do |f| %>


huongnguyenmta · 2017-07-03T15:37:16Z

app/views/shared/_micropost_form.html.erb

+  </span>
+<% end %>
+
+<script type="text/javascript">


move this code javascript into file .js

huongnguyenmta · 2017-07-03T15:38:18Z

app/views/users/show.html.erb

+  <div class="col-md-8">
+    <% if @user.microposts.any? %>
+      <h3>
+        <%= t ".micopost" %>(<%= @user.microposts.count %>)


Ở đây có đang chọc vào db từ view không nhỉ?

không ạ, biến @user đã được định nghĩa tại controller rồi ạ, nên dữ liệu tại đây là do controller truyền đến

Bạn tìm hiểu điểm giống và khác nhau giữa: count, size vs length nhé

huongnguyenmta · 2017-07-03T15:38:46Z

commented

nghiadk1102 · 2017-07-04T01:36:27Z

ready

huongnguyenmta · 2017-07-04T07:10:02Z

commented

nghiadk1102 · 2017-07-04T07:25:10Z

ready

lamhh26 · 2017-07-04T07:41:39Z

app/assets/javascripts/custom.js

@@ -0,0 +1,8 @@
+$(document).ready(function(){
+    $("#micropost_picture").bind("change", function() {


$("#micropost_picture").change() được không, bind() cũ rồi 😁

lamhh26 · 2017-07-04T07:43:53Z

app/models/micropost.rb

+class Micropost < ApplicationRecord
+  belongs_to :user
+
+  scope :time_desc, -> {order created_at: :desc}


->{order created_at: :desc}

lamhh26 · 2017-07-04T07:48:20Z

commented

nghiadk1102 · 2017-07-04T07:57:12Z

ready

dieunb · 2017-07-05T05:33:06Z

merged-ignore thư mục public/uploads đi nhé

nghiadk1102 force-pushed the user-microposts branch 2 times, most recently from 186c4ee to 12b6c86 Compare July 3, 2017 02:14

huongnguyenmta reviewed Jul 3, 2017

View reviewed changes

nghiadk1102 force-pushed the user-microposts branch 2 times, most recently from 854ebde to f0cb72c Compare July 4, 2017 01:34

nghiadk1102 force-pushed the user-microposts branch from f0cb72c to 888ea6d Compare July 4, 2017 01:37

nghiadk1102 force-pushed the user-microposts branch from 888ea6d to 7033881 Compare July 4, 2017 07:24

lamhh26 reviewed Jul 4, 2017

View reviewed changes

Add user microposts

25b05b8

nghiadk1102 force-pushed the user-microposts branch from 7033881 to 25b05b8 Compare July 4, 2017 07:55

		@@ -0,0 +1,8 @@
		$(document).ready(function(){
		$("#micropost_picture").bind("change", function() {

Conversation

nghiadk1102 commented Jul 3, 2017

Uh oh!

nghiadk1102 commented Jul 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huongnguyenmta commented Jul 3, 2017

Uh oh!

nghiadk1102 commented Jul 4, 2017

Uh oh!

huongnguyenmta commented Jul 4, 2017

Uh oh!

nghiadk1102 commented Jul 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lamhh26 commented Jul 4, 2017

Uh oh!

nghiadk1102 commented Jul 4, 2017

Uh oh!

dieunb commented Jul 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants