Skip to content

Commit

Permalink
Remove format script in favor of wider biome check in lint
Browse files Browse the repository at this point in the history
  • Loading branch information
imxeno committed May 18, 2024
1 parent d083ffc commit 78558bf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 41 deletions.
37 changes: 2 additions & 35 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- name: Build
run: pnpm build
format:
biome:
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -71,38 +71,5 @@ jobs:
- name: Install dependencies
run: pnpm install

- name: Run format
run: pnpm format
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v4

- uses: pnpm/action-setup@v4
name: Install pnpm
with:
run_install: false

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v4
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install

- name: Run lint
- name: Run biome
run: pnpm lint
6 changes: 2 additions & 4 deletions apps/bot/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
"scripts": {
"build": "tsc",
"dev": "nodemon -e js,mjs,cjs,ts,mts,cts,json --ignore dist --exec 'rimraf dist && tsc && node dist/main.js'",
"format": "biome check . ./src",
"format:fix": "biome format --write ./src",
"lint": "biome lint ./src",
"lint:fix": "biome lint --apply ./src",
"lint": "biome check ./src",
"lint:fix": "biome check --apply ./src",
"start": "node dist/main.js"
},
"keywords": [],
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
"scripts": {
"build": "turbo build",
"dev": "turbo dev",
"format": "turbo format",
"format:fix": "turbo format:fix",
"lint": "turbo lint",
"lint:fix": "turbo lint:fix"
},
Expand Down

0 comments on commit 78558bf

Please sign in to comment.