Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Fix IPv6 tests and reduce logging noise in test suite

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner October 24, 2025 10:45
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.97%. Comparing base (1b34946) to head (1fa34e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4163      +/-   ##
==========================================
- Coverage   85.99%   85.97%   -0.03%     
==========================================
  Files         131      131              
  Lines       14063    14063              
  Branches       35       35              
==========================================
- Hits        12094    12091       -3     
- Misses       1769     1771       +2     
- Partials      200      201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tataruty tataruty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd expect more logs turned off :D because not only "not found" can be noisy there.
I was thinking to use options.logEnabled parameter for all tests and add this to test execution configuration as run parameter, but had no time then. But still thinking about it

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ciarams87 ciarams87 enabled auto-merge (squash) October 25, 2025 07:26
@ciarams87 ciarams87 merged commit 00f8cd4 into main Oct 25, 2025
61 of 62 checks passed
@ciarams87 ciarams87 deleted the chore/small-fixes branch October 25, 2025 07:56
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants