Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Function constructor handling when called without arguments. #754

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

VadimZhestikov
Copy link
Contributor

Proposed changes

Fixed Function w/o args called relative an object.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@xeioex xeioex marked this pull request as ready for review July 5, 2024 23:08
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to improve the commit message, something like

Fixed Function constructor handling when called with zero arguments.

Corrected the behavior of Function.constructor() when invoked without arguments relative to an object.

@VadimZhestikov VadimZhestikov changed the title Fixed Function w/o args called relative an object. Fixed Function constructor handling when called without arguments relative to an object. Jul 6, 2024
@xeioex
Copy link
Contributor

xeioex commented Jul 6, 2024

The commit log message length being less than 67 chars still applies.

xeioex
xeioex previously requested changes Jul 6, 2024
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit log message length being less than 67 chars still applies.

@VadimZhestikov VadimZhestikov force-pushed the fix-Function branch 2 times, most recently from e023d97 to 57b2cbb Compare July 6, 2024 01:07
@VadimZhestikov VadimZhestikov changed the title Fixed Function constructor handling when called without arguments relative to an object. Fixed Function constructor handling when called without arguments. Jul 6, 2024
@VadimZhestikov VadimZhestikov dismissed xeioex’s stale review July 6, 2024 01:13

No changes in filke, only in commit message

Corrected the behavior of Function.constructor() when invoked without arguments
relative to an object.
@xeioex xeioex merged commit b593dd4 into nginx:master Jul 6, 2024
1 check passed
@VadimZhestikov VadimZhestikov deleted the fix-Function branch July 11, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants