Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine-related commit for detecting version in generate-stackbrew-library.sh #917

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jnoordsij
Copy link
Contributor

Proposed changes

When reviewing docker-library/official-images#17368, I noticed it still incorrectly uses Alpine 3.19 in the generated list of tags for the new images. This is due to the commit being used to check for the Alpine version is inherited from earlier in the script, with it being the last commit that alters the Debian variant.

This PR updates the script to use the latest commit altering the Alpine (slim) image Dockerfile to correctly detect the current used Alpine version.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@thresheek thresheek merged commit 8f11e7e into nginxinc:master Aug 15, 2024
9 checks passed
@jnoordsij jnoordsij deleted the fix-alpine-version-detect branch August 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants