-
Couldn't load subscription status.
- Fork 6
Fix callouts with headers in tab groups not rendering #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean up the exampleSite based on the pipleine? We don't want to encourage these shortcodes from being used.
|
I'll check it out 🫡 |
7a2b2d2 to
24b65da
Compare
✅ Deploy Preview will be available once build job completes!
|
07a3918 to
f40778c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the old "plain" shortcodes. Not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove old "plain" callouts usages in other files such as test-product/everything.md.
Do not outright remove everything. We still want to preserve the original intent of whatever was using the old "plain" shortcodes, so in some cases, a rewrite is needed. For example, in test-product/call-out/call-out-code-lists.md, we need to rewrite the two note shortcodes.
f40778c to
f6faf8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove old shortcodes.
Besides that, LGTM.
f6faf8d to
49777a0
Compare
49777a0 to
d77a6a7
Compare
Proposed changes
Callouts with headers (important, caution, warning, and deprecated) and no custom title were incorrectly rendering inside of tab groups. This fix prevents that by checking if there is a title, if not it uses the typing of the call-out.
In addition I've removed the deprecated examples within the site, so only up-to-date examples are on it.
I've included the before and after for callouts within tab groups and outside of. There has been noticeable change to regular, non-tabbed, loud callouts.
This is in response to this issue: nginx/documentation#1163
Thanks @JTorreG for the clarification on the issue and your workaround!
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)