Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: nginx-aws-signature lib submodule #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shawnhankim
Copy link
Collaborator

Background:

  • As a SWE, I want to reuse nginx-aws-signature lib for not only S3 gateway but also other AWS services gateway such as Lambda gateway.

Description:

  • Move aws signature lib into the repo nginx-aws-signature
  • Sparse checkout the submodule in the nginx-s3-gateway.
  • Changed the name of environment variables of AWS credentials for common AWS signature lib.

@dekobon
Copy link
Collaborator

dekobon commented May 9, 2023

Rather than a submodule, would you consider distributing the aws signature library via npm?

@shawnhankim
Copy link
Collaborator Author

Rather than a submodule, would you consider distributing the aws signature library via npm?

Thanks @dekobon for your comment. It is a great point! Sure, I will consider it. In the meantime, I would appreciate it if you could review #126 as the first step when you get a chance.

@ivanitskiy
Copy link

Rather than a submodule, would you consider distributing the aws signature library via npm?

Thanks @dekobon for your comment. It is a great point! Sure, I will consider it. In the meantime, I would appreciate it if you could review #126 as the first step when you get a chance.

@shawnhankim, Did you get a chance to experiment with distributing via NPM of this nginx-aws-signature lib? I'm considering NPM for my use case and would like to learn/see what experience for NJS modules looks like.

@shawnhankim
Copy link
Collaborator Author

shawnhankim commented Jun 23, 2023

Rather than a submodule, would you consider distributing the aws signature library via npm?

Thanks @dekobon for your comment. It is a great point! Sure, I will consider it. In the meantime, I would appreciate it if you could review #126 as the first step when you get a chance.

@shawnhankim, Did you get a chance to experiment with distributing via NPM of this nginx-aws-signature lib? I'm considering NPM for my use case and would like to learn/see what experience for NJS modules looks like.

@ivanitskiy , Thanks for the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants