Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CORS headers for 404 status code #159

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add missing CORS headers for 404 status code #159

merged 1 commit into from
Aug 4, 2023

Conversation

Fr1z2r
Copy link
Contributor

@Fr1z2r Fr1z2r commented Aug 4, 2023

When file not exist in s3 nginx return 404 response without CORS headers.

dekobon
dekobon approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dekobon dekobon merged commit 6c65b9a into nginxinc:master Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fr1z2r @dekobon