Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed directory listing prefixing #160

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fixed directory listing prefixing #160

merged 1 commit into from
Aug 4, 2023

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Aug 4, 2023

No description provided.

@dekobon
Copy link
Collaborator

dekobon commented Aug 4, 2023

Hello, can you explain what problem this fix solves for?

@zc-devs
Copy link
Contributor Author

zc-devs commented Aug 4, 2023

Sure. DIRECTORY_LISTING_PATH_PREFIX doesn't work anymore.

In e8295ef location @s3Directory was introduced. It's copy-paste from location @s3Listing except xslt_string_param rootPath '${DIRECTORY_LISTING_PATH_PREFIX}'; line which passes env var to listing template.

dekobon
dekobon approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this issue and fixing it.

@dekobon dekobon merged commit 1b4c306 into nginxinc:master Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zc-devs @dekobon