Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small fixes to test scripts and README for clarity #161

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

4141done
Copy link
Collaborator

@4141done 4141done commented Aug 7, 2023

What

Small changes to the documentation and test runner comments to improve the integration test writing experience.

Changes:

  1. Clarified the name of the minio tool required since it took a few minutes of searching
  2. Documented the purpose and acceptable values of the many params to the integration test runner function

Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent contribution. Thank you.

@4141done 4141done merged commit d6039f3 into master Aug 7, 2023
2 checks passed
@@ -55,7 +55,7 @@ additional modules.

## Testing

Automated tests require `docker`, `docker-compose`, `curl`, `mc` and `md5sum` to be
Automated tests require `docker`, `docker-compose`, `curl`, and `mc` (the minio [cli tool](https://github.com/penpyt/asdf-mc)) to be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for writing in closed issue, but official Minio CLI is there https://github.com/minio/mc.

elJosho pushed a commit to elJosho/nginx-s3-gateway that referenced this pull request Oct 25, 2023
* chore: small fixes to test scripts and README for clarity
@4141done 4141done deleted the test-docs-fixes branch April 25, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants