-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eks pod identity credentials support #252
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Thank you for your contribution, @tieum 🎉 I will make some time to understand and review this week.
|
|
Thank you for the explanation and for the very clean pull request. I think this is a great addition to the library. I have two requests before we merge:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🎉 🐳
This all looks great. Once again we very much appreciate your contribution!
Proposed changes
Add support of EKS pod identities
Checklist
I have read the contributing guidelines.
I have signed the F5 Contributor License Agreement (CLA).
If applicable, I have added tests that prove my fix is effective or that my feature works.
--> I didn't manage to add the correct test, however I didn't find any for webIdentity auth neither
I have updated any relevant documentation (e.g.
README.md
).--> there is a nice .png for which I didn't have the source to add
_fetchEKSPodIdentityCredentials
in the list