forked from KelvinTegelaar/CIPP
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from KelvinTegelaar:main #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
191
commits into
ngms-psh:main
Choose a base branch
from
KelvinTegelaar:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional rendering based on settings.isInitialized was removed from _app.js, allowing the main app components to render regardless of initialization state. Also, minor formatting changes were made to the CippTenantSelector effect dependencies for readability.
Simplifies tenant selection by making the URL parameter the single source of truth for tenant changes. Updates settings only when the URL changes, and removes redundant settings updates from the selection handler. Also streamlines effect dependencies and improves comments for clarity.
Introduced helper functions to remove unnecessary 'tenantFilter' query parameters and to clean 'AllTenants' from page titles in breadcrumbs. Updated all relevant breadcrumb and navigation logic to use these helpers, ensuring cleaner URLs and more accurate breadcrumb titles throughout the component. Added debug logging for easier troubleshooting.
Eliminated multiple console.log statements used for debugging in CippBreadcrumbNav.jsx to clean up the code and reduce console noise.
Moved and renamed standards-related pages for better organization, including aligning routes under /tenant/standards/alignment and /tenant/standards/templates. Updated navigation paths and tab options accordingly. Enhanced the alignment page with new drift management actions and removed obsolete files.
Refines the 'hasValue' comparison to better handle arrays and falsy values, ensuring more accurate condition evaluation. Also updates the prop validation to allow undefined compareValue only for 'hasValue' type.
Deleted the 'addedField' property from the ListIntuneTemplates-tag-autcomplete API config in standards.json to clean up unused configuration.
Simplifies tenant selection by making the URL parameter the single source of truth for tenant changes. Updates settings only when the URL changes, and removes redundant settings updates from the selection handler. Also streamlines effect dependencies and improves comments for clarity.
Introduced helper functions to remove unnecessary 'tenantFilter' query parameters and to clean 'AllTenants' from page titles in breadcrumbs. Updated all relevant breadcrumb and navigation logic to use these helpers, ensuring cleaner URLs and more accurate breadcrumb titles throughout the component. Added debug logging for easier troubleshooting.
Eliminated multiple console.log statements used for debugging in CippBreadcrumbNav.jsx to clean up the code and reduce console noise.
Moved and renamed standards-related pages for better organization, including aligning routes under /tenant/standards/alignment and /tenant/standards/templates. Updated navigation paths and tab options accordingly. Enhanced the alignment page with new drift management actions and removed obsolete files.
Refines the 'hasValue' comparison to better handle arrays and falsy values, ensuring more accurate condition evaluation. Also updates the prop validation to allow undefined compareValue only for 'hasValue' type.
Deleted the 'addedField' property from the ListIntuneTemplates-tag-autcomplete API config in standards.json to clean up unused configuration.
Changed all references from '/tenant/standards/list-standards' to '/tenant/standards' across components, hooks, and pages for consistency. Deleted the now-obsolete list-standards page implementation.
Added a getPathInfo helper to resolve breadcrumb titles from navigation or tab options and validate paths. Breadcrumbs now display titles from navigation/tabs when available and render invalid paths as plain text instead of clickable links.
Wrapped the CreateGroups switch in a CippFormCondition component to disable it unless 'Replace by display name' is selected. Added dynamic helper text to clarify group creation behavior based on the selected replace mode.
Update package.json and public/version.json to reflect the new version 8.8.2.
testing done, bumping hf.
queryKey tweaks
Workflow was missing token as part of the required usage. https://github.com/JasonEtco/is-sponsor-label-action?tab=readme-ov-file#usage Reusing existing token value inside of the repository as referenced by other workflows Changed the label to match the one on GitHub Signed-off-by: Luke Steward <29278153+LukeSteward@users.noreply.github.com>
Updated the permissions for the 'Mailbox Permissions' menu item from 'Exchange.Mailbox.Read' to 'Exchange.Mailbox.*' to allow broader access. This change enables users with any Exchange mailbox permission to access the menu.
Fixed failed labeling workflow
Secure Score Alert
Updated the log entry view action to include the dateFilter parameter in the URL. Modified logentry.js to extract dateFilter from the query and pass it to the API call for fetching log details. Also improved code formatting for severity badge rendering.
Added status code 302 and 500 to the list of HTTP statuses that should not trigger retries in ApiGetCallWithPagination. When a 302 redirect to the AAD login is detected, the 'authmecipp' query is invalidated. Also fixed minor formatting and trailing comma issues in several functions.
Introduces a new page for viewing calendar permissions, allowing grouping by user or calendar. Includes cache sync functionality and displays cached data from the reporting database, with support for multi-tenant views.
Displays the tenant region using OpenIdConfig. Also updates the fallback text for tenant brand name from 'N/A' to 'Not Specified'.
- Introduced a new button to restore default excluded licenses. - Added a dialog for confirming the restore action.
Extended user and group pages to display additional license-related fields, including 'licenseAssignmentStates' for users and several license and sync fields for groups. Updated getCippFormatting to handle and format 'licenseAssignmentStates' for display, including transforming and rendering the data as a table.
Introduces a new user action for reprocessing license assignments, including confirmation text and conditional availability based on write permissions. implements #5163
Feat: Add restore default excluded licenses feature
Dev to hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )