Skip to content

Conversation

@Whassup
Copy link

@Whassup Whassup commented Sep 8, 2015

Hi Nico,

What are your thoughts about the following updates?

  • Updated to use jcmdline-2.0.0
  • Updated to include cli option for setting documentation file extension.

The main reason I was thinking about this change so that markdown files can be generated for documentation, which works well with putting docs on github.

NOTE: I didn't update to newest jcmdline for any specific reason.

- Updated to use jcmdline-2.0.0
- Updated to include cli option for setting documentation file extension.
@nguillaumin
Copy link
Owner

Hi, sorry for the late reply I was travelling.

Changes looks good. For jcmdline I don't really like it but that's what the original project used and changing it was too much work. Too bad v2.0.0 is still not available on Maven...

Happy to merge if you could address some minor things:

  • Could you update the command to install jcmdline in the README (now v2.0.0)?
  • There seem to be a bunch of changes due to whitespace differences, presumably an IDE setting to tweak? If you could get rid of those that would make the diff cleaner...

Markdown would be good yeah, presumably that can be achieved mostly with another set of templates?

Cheers,

Nico

nguillaumin pushed a commit that referenced this pull request Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants