Skip to content

Fix callPackage still producing dynamic executables #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix callPackage still producing dynamic executables #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions survey/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,11 +1709,15 @@ let
])
]);
in
final.lib.mapAttrs
(final.lib.mapAttrs
(name: value:
if (isProperHaskellPackage value && isExecutable value) then statify value else value
)
super
super) // {
Comment on lines +1712 to +1716
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping I could get rid of this map, as the callPackage override would take over its functionality. That doesn't appear to happen, though, and leaving this out will cause any regular executables to be dynamically linked.

callPackage = path: args:
let value = super.callPackage path args; in
if (isProperHaskellPackage value && isExecutable value) then statify value else value;
}
);
});
};
Expand Down