Skip to content

Commit

Permalink
fix: send back refresh token after a sign-in with pat (#412)
Browse files Browse the repository at this point in the history
* fix: send back refresh token after a signin with pat

* chore: add changeset
  • Loading branch information
onehassan authored Sep 15, 2023
1 parent 44c7d9e commit 4eff7f4
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/pink-pans-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'hasura-auth': patch
---

fix: send back refresh token upon sign-in with pat
16 changes: 13 additions & 3 deletions src/routes/signin/pat.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { sendError } from '@/errors';
import { logger } from '@/logger';
import { ENV, createHasuraAccessToken, getUser, getUserByPAT } from '@/utils';
import {
ENV,
createHasuraAccessToken,
getNewRefreshToken,
getUser,
getUserByPAT,
} from '@/utils';
import { personalAccessToken } from '@/validation';
import { RequestHandler } from 'express';
import Joi from 'joi';
Expand Down Expand Up @@ -28,13 +34,17 @@ export const signInPATHandler: RequestHandler<
const accessToken = await createHasuraAccessToken(user);
const sessionUser = await getUser({ userId: user.id });

const { refreshToken, id: refreshTokenId } = await getNewRefreshToken(
user.id
);

return res.send({
mfa: null,
session: {
accessToken,
accessTokenExpiresIn: ENV.AUTH_ACCESS_TOKEN_EXPIRES_IN,
refreshToken: null,
refreshTokenId: null,
refreshToken: refreshToken,
refreshTokenId: refreshTokenId,
user: sessionUser,
},
});
Expand Down

0 comments on commit 4eff7f4

Please sign in to comment.