Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(hasura-auth) keep select and delete permissions already set in metadata for auth tables instead of overriding them #407

Merged
merged 2 commits into from
Jul 12, 2023
Merged

bugfix(hasura-auth) keep select and delete permissions already set in metadata for auth tables instead of overriding them #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d40d77
bugfix(hasura-auth) keep select and delete permissions already set in…
juicygoose Jul 11, 2023
5c7f3b0
chore: add changeset
onehassan Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-parrots-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'hasura-auth': patch
---

fix: merge new select/delete permissions with the existing ones
10 changes: 8 additions & 2 deletions src/utils/hasura-metadata/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,17 @@ export const patchTableObject = (
}

if (select_permissions) {
existingTable.select_permissions = [...select_permissions];
const mergedSelectPermissions = [...(existingTable.select_permissions ?? []), ...select_permissions];
existingTable.select_permissions = [
...new Map(mergedSelectPermissions.map((permission) => [permission.role, permission])).values()
];
}

if (delete_permissions) {
existingTable.delete_permissions = [...delete_permissions];
const mergedDeletePermissions = [...(existingTable.delete_permissions ?? []), ...delete_permissions];
existingTable.delete_permissions = [
...new Map(mergedDeletePermissions.map((permission) => [permission.role, permission])).values()
];
}

// TODO merge other fields (permissions, computed fields, etc.) - not required by Hasura-auth yet
Expand Down