Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount oauth and healthz routes correctly when specifying AUTH_API_PREFIX #433

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

dbarrosop
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 642e7a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hasura-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +59 to +62
app.use('/', (_req, res) => {
return sendError(res, 'bad-request');
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

@dbarrosop dbarrosop merged commit 044ed00 into main Nov 7, 2023
4 checks passed
@dbarrosop dbarrosop deleted the prefix branch November 7, 2023 10:40
@dminkovsky
Copy link

It appears that healthz is still broken after this. For example, when I run:

 docker run -p 4001:4000 --rm --network nhost-local_default -e "HASURA_GRAPHQL_ADMIN_SECRET=secret" -e "HASURA_GRAPHQL_DATABASE_URL=postgres://postgres:secret-pg-password-never-use-this-value@postgres:5432/postgres" -e "HASURA_GRAPHQL_GRAPHQL_URL=http://graphql-engine:8080/v1/graphql" -e "HASURA_GRAPHQL_JWT_SECRET=$HASURA_GRAPHQL_JWT_SECRET" nhost/hasura-auth:0.22.0
$ curl localhost:4001/version
{"version":"v0.22.0"}

but

$ curl localhost:4001/healthz
{"status":404,"message":"Route not found","error":"route-not-found"}

@dbarrosop
Copy link
Member Author

See #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants