fix: conceal error if AUTH_CONCEAL_ERRORS is set #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b13513 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the PR @ErwinPetit LGTM @onehassan anything to add? |
|
LGTM! Thanks for the PR @ErwinPetit 🙌 . I'll add a changeset and merge! |
|
@ErwinPetit it seems I can't push to your repo, can you unlock your main branch? |
|
Oops sorry @onehassan . I unlocked the branch, it might be good ! |
|
Yes that worked - thanks @ErwinPetit 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR:
Checklist
Changes
When AUTH_CONCEAL_ERRORS is used, the error code in the response is also concealed
Tests
Snapshot for conceal-error.test.ts has been updated