Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-3136 Enable distance selling #1034

Merged
merged 23 commits into from
Nov 26, 2024
Merged

DS-3136 Enable distance selling #1034

merged 23 commits into from
Nov 26, 2024

Conversation

ThomasC-Kainos
Copy link
Contributor

@ThomasC-Kainos ThomasC-Kainos commented Nov 12, 2024 •
edited
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-3136

Description of Changes

Added a new constant DistanceSelling to the OrganisationSubType list

Type of change

Delete not appropriate

  • New feature (non-breaking change which adds functionality)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@ThomasC-Kainos ThomasC-Kainos marked this pull request as ready for review November 19, 2024 10:34
@ThomasC-Kainos ThomasC-Kainos changed the title Task/ds 3136 enable distance selling Task/ds-3136 enable distance selling Nov 19, 2024
@ThomasC-Kainos ThomasC-Kainos changed the title Task/ds-3136 enable distance selling task/DS-3136_Enable_distance_selling Nov 19, 2024
@mabe13 mabe13 changed the title task/DS-3136_Enable_distance_selling DS-3136 Enable_distance_selling Nov 20, 2024
@mabe13 mabe13 changed the title DS-3136 Enable_distance_selling DS-3136 Enable distance selling Nov 20, 2024
@mabe13 mabe13 force-pushed the task/DS-3136_Enable_distance_selling branch from c81bf5a to 840b808 Compare November 21, 2024 15:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mabe13 mabe13 requested a review from nsindhu26 November 21, 2024 19:02
@mabe13
Copy link
Collaborator

mabe13 commented Nov 21, 2024

LGTM 👍
Have given it a quick review, handed it over to @nsindhu26 for final approval

@mabe13 mabe13 self-requested a review November 26, 2024 13:41
mabe13
mabe13 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fully reviewed 👍
Happy for the ticket to be merged

@ThomasC-Kainos ThomasC-Kainos merged commit 4089ad2 into develop Nov 26, 2024
14 checks passed
@ThomasC-Kainos ThomasC-Kainos deleted the task/DS-3136_Enable_distance_selling branch November 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabe13 mabe13 mabe13 approved these changes

@nsindhu26 nsindhu26 Awaiting requested review from nsindhu26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasC-Kainos @mabe13 @ManithaSrinivasa