DS-1317 Create Quality Checker Lambda #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
57ed01e to
ec63f79
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
c6c8815 to
2a2c839
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
5 times, most recently
from
f43a09f to
6ccb6be
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
6ccb6be to
ad7bd9b
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
7620bfb to
c83782c
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
2 times, most recently
from
d8a39c7 to
510db19
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
4 times, most recently
from
3fea048 to
182c8b4
Compare
mabe13
previously approved these changes
Oct 20, 2023
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
182c8b4 to
1214ace
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
4 times, most recently
from
dc6fa8f to
34ae106
Compare
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
2 times, most recently
from
55a5ce7 to
fa75ab1
Compare
Bump up versions Begin adding quality checker values and updating variables Bump up requirements Improve variable names and use terraform jsonencode Update more terraform Add serverless cron Add more dos searching Add base level reporting functions Reduce code duplication and log on z code incorrectly profiled Start unit tests Increase unit test coverage Add schedule and deployment changes Add job complete and incomplete alarms Fix incorrect alarm threshold Sort issues after rebase Fix dependency conflict Fix rebase error Fix more rebase errors Increase unit test coverage Add additional quality checker metric Add adr document Add missing functionality Fix unit tests
JackPlowman
force-pushed
the
task/DS-1317_Data_Quality_Checker
branch
from
fa75ab1 to
ddb8e81
Compare
|
Kudos, SonarCloud Quality Gate passed! |
vkjonnagadda
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Branch Pull Request
https://nhsd-jira.digital.nhs.uk/browse/DS-1317
Description of Changes
This PR adds a Quality Checker lambda to review the data within the DoS database.
Type of change