Align design of import table to prototype #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single table and change the status item colours and text.
This is back to being a single table.
This does the process followed by the record step in sequence which means users don't have to manually go in and press "Upload records".
This is no longer necessary now that imports get recorded immediately after processing in the background job.
|
thomasleese
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
AppImportTablesComponentback toAppImportsTableComponentnow that the prototype is updated.Remove the need for the
editpage by consolidating into theshowview.Future PRs will probably unify the
showtemplates for all 3 upload types as well as aligning that to the prototype further.Review without whitespace changes.
Screenshots