Skip to content

Commit

Permalink
Update windows build platform toolset version (#705)
Browse files Browse the repository at this point in the history
Looks like the [windows build agents updated
recently](https://github.com/actions/runner-images/releases/tag/win22%2F20240624.1)
and now platform toolset v141 did not resolve anymore giving error:

```
MSBuild version 17.10.4+10fbfbf2e for .NET Framework
Build started 7/3/2024 9:22:16 PM.

     1>Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" on node 1 (default targets).
     1>ValidateSolutionConfiguration:
         Building solution configuration "Debug|Win32".
     1>Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (1) is building "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (2) on node 1 (default targets).
     2>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(49,5): error MSB[8](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:9)037: The Windows SDK version 10.0.20348.0 for Desktop C++ Win32 Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj]
     2>Done Building Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (default targets) -- FAILED.

Build FAILED.

       "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (default target) (1) ->
       "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (default target) (2) ->
       (_CheckWindowsSDKInstalled target) -> 
         C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(4[9](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:10),5): error MSB8037: The Windows SDK version [10](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:11).0.20348.0 for Desktop C++ Win32 Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:[13](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:14).42
```

Which is a not great error because Windows SDK version 10.0.20348.0 is
installed but I guess PlatformToolset v141 wasn't. The [installed
software
list](https://github.com/actions/runner-images/blob/releases/win22/20240624/images/windows/Windows2022-Readme.md)
shows a couple things VC++ related at v142 so just went with that
  • Loading branch information
rajsite authored Jul 3, 2024
1 parent c5aa125 commit 3f0aab6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Vireo_VS/VireoCommandLine.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,13 @@
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<PlatformToolset>v141</PlatformToolset>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>NotSet</CharacterSet>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<UseDebugLibraries>false</UseDebugLibraries>
<PlatformToolset>v141</PlatformToolset>
<PlatformToolset>v142</PlatformToolset>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>NotSet</CharacterSet>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion docs/Build.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Notice that vireo.js is created in the `dist` folder based on the `BUILD` type.

- Visual Studio 2022 with C++ support, specifically:
- Windows 10 SDK (10.0.20348.0)
- MSVC v141 - VS 2017 C++ x64/x86 build tools (v14.16)
- MSVC v142 - VS 2019 C++ x64/x86 build tools (v14.29)

### Building Vireo Windows Native

Expand Down

0 comments on commit 3f0aab6

Please sign in to comment.