Specify node version #67
Conversation
ChrisStrykesAgain
requested review from
cameronwaterman and
pvallone
as code owners
bump down to 18 for consistency with current implementation
|
@rajsite @cameronwaterman @atmgrifter00 These changes lay the foundation for the rest of my PRs. All I've done here is set a specific node version for the build system (which matches the previously assumed default). In a subsequent PRs I'll update it to use node 20, but to avoid a kitchen sink PR I'm trying to be a bit more surgical. |
…my package." This reverts commit 30ca73b.
|
@atmgrifter00 @cameronwaterman is there a reason it wasn't merged after finishing review as code owners? What's the expected workflow? @ChrisStrykesAgain you had mentioned a concern about merge timings does that apply here? Are we waiting for merge? |
|
@rajsite - Are you suggesting we should auto-merge after owners review? I expected we followed a similar pattern as we do with AzDO where the PR creator merges the PR when they're ready. |
On GitHub only collaborators are allowed to merge source code, i.e. PRs can be opened by anyone as these are public projects but can only be merged into the codebase by those with write access. There are patterns to say give all NI employees (those in the ni github org) write access to merge approved PRs but that is not how this repo is configured. |
I see - I thought that functionality was opt-out instead of opt-in. Shows you how much I use GitHub 😆 I just added Chris as a "write" Collaborator so he can at least merge his own PRs when he's ready. |
This is work required for #64, but doesn't complete that issue fully. That will be done in a subsequent PR in an attempt to be a little more surgical with my changes and avoid a kitchen sink PR.