Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shunt Cal support in grpc-device #1033

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Add Shunt Cal support in grpc-device #1033

merged 8 commits into from
Jan 18, 2024

Conversation

charitylxy
Copy link
Contributor

What does this Pull Request accomplish?

  • Validate the changes made in grpc-device-scrapigen PR
  • Generate nidaqmx.proto file which will be used in nidaqmx-python PR
  • Add system test coverage for shunt cal methods.

Why should this Pull Request be merged?

To add shunt cal methods to grpc-device.

What testing has been done?

  • Built successfully.
  • Eyeball inspection of the generated files.

@charitylxy charitylxy requested review from bkeryan and zhindes January 10, 2024 15:20
@bkeryan bkeryan added the source-breaking Change to proto file that will break client if they update label Jan 10, 2024
@zhindes zhindes removed their request for review January 10, 2024 19:18
@zhindes
Copy link
Contributor

zhindes commented Jan 10, 2024

I removed myself. I'm not a grpc-device expert, and y'all got this :)

@bkeryan bkeryan mentioned this pull request Jan 11, 2024
Merged
@charitylxy charitylxy requested a review from bkeryan January 16, 2024 05:38
bkeryan
bkeryan requested changes Jan 16, 2024
View reviewed changes
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
@charitylxy charitylxy requested a review from bkeryan January 18, 2024 05:32
bkeryan
bkeryan approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
source/tests/system/nidaqmx_driver_api_tests.cpp Outdated Show resolved Hide resolved
@charitylxy charitylxy merged commit d34bbe8 into ni:main Jan 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckenro reckenro reckenro approved these changes

@astarche astarche astarche approved these changes

@bkeryan bkeryan bkeryan approved these changes

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
source-breaking Change to proto file that will break client if they update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charitylxy @zhindes @bkeryan @astarche @reckenro