Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sideband port configurable via json file. #1126

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Make sideband port configurable via json file. #1126

merged 5 commits into from
Nov 27, 2024

Conversation

amehra-ni
Copy link
Contributor

@amehra-ni amehra-ni commented Nov 21, 2024 •
edited
Loading

What does this Pull Request accomplish?

There were some unresolved comments in the previous PR. Two of them are being addressed in this PR.

  • The sideband port should not be hardcoded and instead should be configurable via service_cofig.json file.

Why should this Pull Request be merged?

  • Exposed a new member sideband_port and used that for initialization.
  • Created out a helper which extracts port. Used it at two places for extracting port.

What testing has been done?

  • No functional behavior change for grpc-server.
  • We can now configure the sideband port.

@amehra-ni amehra-ni mentioned this pull request Nov 25, 2024
Merged
@amehra-ni amehra-ni marked this pull request as ready for review November 26, 2024 08:41
@amehra-ni amehra-ni merged commit dea3b5a into main Nov 27, 2024
10 checks passed
@amehra-ni amehra-ni deleted the users/amehra/use-config-port branch November 27, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckenro reckenro reckenro approved these changes

@asumit asumit asumit approved these changes

@doshirohan doshirohan Awaiting requested review from doshirohan

@astarche astarche Awaiting requested review from astarche astarche is a code owner

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amehra-ni @asumit @reckenro